Repository navigation
fix: exclude pnpm symlink aliases from completed archives - #15
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for maintaining configure-nodejs. PwrGit uses it across hosted Linux/Windows and persistent macOS runners. Adopting completed pnpm trees exposed two archive portability failures.
The
**/node_modulescache glob follows package symlinks and gives tar both workspace roots and nested dependency directories reached through aliases. Extraction then fails with directory and hard-link errors. After narrowing that manifest, Windows restored some directory aliases as file symlinks when their targets appeared later in the archive:readlinkreturned the correct relative target, but traversal returnedEPERMandproper-lockfilecould not loadretry.Exclude nested
node_modulesmatches from the completed-tree manifest. Each workspace root remains recursively archived, preserving its packages, bin files and links. Record internal directory-link targets in the compatibility marker. After key/ABI validation, Windows restores the directory type only for recorded links whose existing source and internal target still match. Missing or changed edges fail; the action neither installs packages nor infers a dependency graph. Validate every metadata entry before changing any link. Default manager and persistent-store modes are unchanged; the implementation hash separates new completed archives from previous entries.proper-lockfileimport failed. Theretrysymlink had correct target text butstatreturnedEPERM.retryfailure, then passed after the directory-link codec fix. It also executes a real lock operation after restore.Extend the existing pnpm 10/12 lifecycle fixtures with a nested workspace root, package aliases and hard-linked bin files. Same-job and fresh-job consumers verify restored contents, symlinks and native esbuild, with no reinstall. Hosted Linux/macOS/Windows CI is validating the complete matrix. PwrGit PR pwrdrvr/PwrGit#513 is testing immutable fix SHA
311efb2f64811ab65d8943dd7c221de22c2f38d1before merge or release.